Skip to content

alsa-ucm-conf: fix hardcoded path to /bin/rm and /bin/mkdir#371100

Closed
drupol wants to merge 2 commits intoNixOS:stagingfrom
drupol:push-ytnprzvyuluv
Closed

alsa-ucm-conf: fix hardcoded path to /bin/rm and /bin/mkdir#371100
drupol wants to merge 2 commits intoNixOS:stagingfrom
drupol:push-ytnprzvyuluv

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Jan 5, 2025

This fix #294170

Question: Should I add coreutils to buildInputs ?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol marked this pull request as ready for review January 5, 2025 11:23
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dell-xps-13-9320-microphone-not-working/40932/8

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 5, 2025
@nix-owners nix-owners bot requested a review from roastiek January 5, 2025 11:31
@kirillrdy
Copy link
Member

Question: Should I add coreutils to buildInputs ?

my guess would be no

@drupol
Copy link
Contributor Author

drupol commented Jan 5, 2025

I just notice that this should go to staging... rebase ongoing.

@drupol drupol marked this pull request as draft January 5, 2025 11:37
@drupol drupol force-pushed the push-ytnprzvyuluv branch from 66565a1 to 9613a91 Compare January 5, 2025 11:38
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET 6.topic: nvidia Nvidia-specific issues and fixes labels Jan 5, 2025
@drupol drupol changed the base branch from master to staging January 5, 2025 11:38
@drupol drupol marked this pull request as ready for review January 5, 2025 11:39
@drupol drupol requested a review from GaetanLepage January 5, 2025 11:39
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 5, 2025
@drupol
Copy link
Contributor Author

drupol commented Jan 5, 2025

I don't know what is happening

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alsa-ucm-conf refers to /bin/rm and /bin/mkdir

3 participants